[Slackbuilds-users] Patch for libmp4v2

[Heinz Wiesinger]

On Thursday 28 January 2010 11:50:35 Niels Horn wrote:
> On Thu, Jan 28, 2010 at 2:27 AM, Eugéne Suter <easuter at gmail.com> wrote:
> > I'll make future reports more detailed, sorry.
> > Yeah, I'm running 64bit -current.
> >
> > On 28 January 2010 04:10,  <xgizzmo at slackbuilds.org> wrote:
> >> On Wednesday 27 January 2010 22:50:45 Eugéne Suter wrote:
> >>> Hi folks,
> >>>
> >>> Today I was trying to install libmp4v2 and the build failed. I have a
> >>> patch attached for the code and one for the SlackBuild.
> >>>
> >>> Cheers,
> >>> Eugéne
> >>
> >> Eugéne,
> >> Based on the patch it looks like you are running -current, nothing wrong
> >> with that but if you are you need to state that the patch is needed for
> >> -current. If not ignore me.
> >>
> >> --dsomero
>
> Since we're on the subject, what would be reasonable in these cases?
> 
> What if a SlackBuild needs patches for -current?
> I know SlackBuilds.org supports 13.0-stable only officially, but is it
> OK to mention a patch in README if needed? Or create a README.CURRENT
> if there are special instructions?
> 
> Or (tell me if I'm going too far) let the SlackBuild check the version
> of gcc (usually the problem with building on -current) version and
> apply the patch?
> 
> Sometimes (mostly?) a patch for -current will not cause any
> side-effects on -stable and build normally on the "older" gcc. In this
> case I guess we can apply the patch anyway (I confess I already did
> this in one build)

The issue with -current is that it's a moving target. Things might change 
drastically from one day to another. A fix that worked before might need 
adjustments to continue working, or it might no longer be necessary, or ....
That's why we usually see those fixes for current at a far later point, usually 
around rc1 or rc2 of the coming release, because it's less likely that things 
break again at this point.

BUT, that doesn't mean you cannot do anything right now. There's in fact a 
couple of things possible:
 - try a newer version. There's the chance that it fixes the problems. (in case 
of libmp4v2 this would be an option)
 - inform the maintainer of the script about the problem and possible 
solutions you have found.
 - if the problem still exists in the most recent version, or we already have 
the most recent version in the repo, bug upstream. Chances are it will get 
fixed before the release of the next Slackware version.

In case there's really only the way to patch it, I would say it's up to the 
maintainer of the script IMHO. Like David already mentioned, as long as it 
doesn't break stable it should be fine.

I won't include any patch for -current at this time for any of my scripts. 
It's just too early in the development process for that. IMHO, a person 
running -current at this time should be able to fix such problems himself.
But that's just my 2 cents.

Grs,
Heinz
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20100128/07d00c7c/attachment-0001.sig>