[Slackbuilds-users] bashrun2 Slackbuild typo

[Binh Nguyen]

On Fri, 19 Oct 2012 at 01:01 PM -0500, Robby Workman wrote:
> On Fri, 19 Oct 2012 22:19:42 +0700
> Binh Nguyen <binhvng at gmail.com> wrote:
> 
> > On Thu, 18 Oct 2012 at 01:08 PM -0400, Chess Griffin wrote:
> > > Minor typo on line 85 of the SlackBuild:
> > > 
> > > mv $PKG/etc/bash_completion.d/bashrun2
> > > $PKGetc/bash_completion.d/bashrun2.new
> > > 
> > > missing a / after second $PKG so should be:
> > > 
> > > mv $PKG/etc/bash_completion.d/bashrun2
> > > $PKG/etc/bash_completion.d/bashrun2.new
> > 
> > I believe that auto-complete file like this should not be treated as a
> > user-config file, i.e. it should be left as-is and not be renamed to a
> > ".new" file.
> > 
> > What do you maintainers think?
> 
> 
> This is one place where I think we should probably deviate from
> upstream's intentions (and I think that upstream will likely
> catch up to the new bash-completion on this sooner or later).
> Old bash-completion (before 2.x) put the packaged completions
> files in /etc/bash-completion.d/ -- while that directory is still
> supported, /usr/share/bash-completion/completions/ seems to be
> intended as the systemwide/packaged completions directory whereas
> /etc/bash-completion.d/ seems intended for local system overrides
> and additions.

I don't think that's a good approach; it causes 2 issues:

 (a) If upstream still uses /etc/bash_completion.d/, when upgrading
     users would have an additional step of considering the ".new" file
 (b) If upstream converts to /usr/share/bash-completion/completions/,
     when upgrading there would be a leftover file in
     /etc/bash_completion.d

as opposed to clean upgradings whether upstream changes behavior or not.
The ".new" file should only be created when the new location is used by
upstream (and if there's a completion file in old location for local
changes too).