[Slackbuilds-users] [PATCH]

[Robby Workman]

On Sat, 22 Sep 2012 00:24:31 -0500
Kyle Guinn <elyk03 at gmail.com> wrote:

> On 9/21/12, Robby Workman <rworkman at slackbuilds.org> wrote:
> > On Fri, 21 Sep 2012 23:35:32 -0500
> > Kyle Guinn <elyk03 at gmail.com> wrote:
> >
> >> Somebody beat me to updating octave to 3.6.3, but there were some
> >> extra changes in that commit that aren't working for me.  It still
> >> needs the sed-fu to find SuiteSparse headers.
> >>
> >> I've also attached some corrections to REQUIRES.
> >
> >
> > Awesome; thanks, Kyle.
> >
> > I've got commits #'s 1 and 4 in my branch now, but I'm curious
> > about #'s 2 and 3: the jdk dep was added because the resulting
> > package has some sort of jar file in it.  I don't recall the
> > exact greppage we did to find that, so it may very well be a
> > false positive, but before removing the jdk dep, I'd like to
> > confirm for *sure* that it's a false positive...
> 
> 
> I was curious about that jdk dependency too, and I did find a jar file
> in each.  Those .jar files are for some MATLAB stuff that we're
> ignoring.  I built it fine without jdk.


Right - the concern was for runtime.  However, you're the maintainer,
so if the MATLAB stuff is irrelevant, so be it.

I'll get those two patches in soonish.

Thanks!

-RW
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20120922/414ed909/attachment.asc>