[Slackbuilds-users] Bug in google-earth.SlackBuild

[Robby Workman]

On Tue, 23 Apr 2013 02:52:07 +0100
Michiel van Wessem <michiel.van.wessem at gmail.com> wrote:

> Howdy all,
> 
> Seems there is a slight bug in the google-earth.SlackBuild made by me.
> The problem is basically that the extraction of the sources make the
> $PKG directory 0700 which leads to weird problems down the line. 
> 
> The Fix to the problem is the following code below (basically make
> sure that after extracting the sources the permissions on $PKG are
> sane). I'll upload a new tarball to SBo.
> 
> <patch>
> --- google-earth.SlackBuild.orig	2013-04-23 01:23:52.874110820
> +0000 +++ google-earth.SlackBuild	2013-04-23 01:25:30.074320008
> +0000 @@ -48,6 +48,7 @@
>  ar p $CWD/google-earth-stable_current_i386.deb data.tar.lzma | lzma
> -d | tar xv cd $PKG
>  chown -R root:root . 
> +chmod 0755 .
>  find . \
>   \( -perm 777 -o -perm 775 -o -perm 711 -o -perm 555 -o -perm 511 \)
> \ -exec chmod 755 {} \; -o \
> </patch>
> 
> again, mea culpa for this screw up. :|


Well, I missed it on approval :/

Instead of the "chmod 0755" I'd probably do:
  "find . -type d -exec chmod 0755 {} \;"

Re uploading a tarball, no need - this is a bugfix and you're an
admin.  Just fix it in your branch and be done with it.  We'll 
merge it in our next update.

-RW
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20130422/e66406ae/attachment-0001.asc>