[Slackbuilds-users] feh

[joe]

Jorge Almeida <jjalmeida at ...> writes:

> 
> Compiling feh-2.3 on Slackware 14.0 is failing. The two libraries
> mentioned as prerequisites are installed.
> 
> imlib2-1.4.5-i686-1_SBo
> giblib-1.2.4-i686-2_SBo
> 
> TIA
> 
> Jorge Almeida
> 
> make[1]: Entering directory `/slash/var/slack/slackbuild/tmp/feh-2.3/src'
> sed 's/^\(.*\)$/"\1\\n"/' < help.raw > help.inc
> cc  -MM collage.c events.c exif.c feh_png.c filelist.c getopt.c
> getopt1.c imlib.c index.c keyevents.c list.c main.c md5.c menu.c
> multiwindow.c options.c signals.c slideshow.c thumbnail.c timers.c
> utils.c wallpaper.c winwidget.c > deps.mk
> make[1]: Leaving directory `/slash/var/slack/slackbuild/tmp/feh-2.3/src'
> make[1]: Entering directory `/slash/var/slack/slackbuild/tmp/feh-2.3/src'
> cc -O2 -march=native   -c -o collage.o collage.c
> collage.c: In function 'init_collage_mode':
> collage.c:68:11: error: 'PACKAGE' undeclared (first use in this function)
> collage.c:68:11: note: each undeclared identifier is reported only
> once for each function it appears in
> collage.c:69:6: error: expected ')' before string constant
> collage.c:72:6: error: too few arguments to function 'fputs'
> collage.c:78:6: error: expected ')' before string constant
> collage.c:81:6: error: too few arguments to function 'fputs'
> collage.c:111:7: error: expected ')' before string constant
> collage.c:202:28: error: expected ')' before string constant
> make[1]: *** [collage.o] Error 1
> 

The feh build is not inheriting the slackbuild CFLAGS well.  This will work
around that:

--- feh.SlackBuild.ori  2013-03-24 23:22:00.641550918 -0600
+++ feh.SlackBuild      2013-03-24 23:39:26.123480592 -0600
@@ -71,8 +71,8 @@
  -exec chmod 644 {} \;
 
 make \
-  CFLAGS="$SLKCFLAGS" \
-  PREFIX=/usr
+  CFLAGS="-g $SLKCFLAGS -Wall -Wextra -pedantic -DPREFIX=\\\"/usr\\\"
-DHAVE_LIBCURL -DHAVE_LIBXINERAMA -DPACKAGE=\\\"$PRGNAME\\\"
-DVERSION=\\\"$VERSION\\\""
+
 make install \
   DESTDIR=$PKG \
   PREFIX=/usr \