[Slackbuilds-users] Package for TLP

[Aaditya Bagga]

JK Wood wrote:
>
>
> On Nov 19, 2013 11:15 AM, "Aaditya Bagga" <abchk1234 at gmail.com 
> <mailto:abchk1234 at gmail.com>> wrote:
> >
> > Aaditya Bagga wrote:
> >>
> >> Aaditya Bagga wrote:
> >>>
> >>> Hey folks!
> >>>
> >>> I have built a package for TLP.
> >>>
> >>> http://linrunner.de/en/tlp/tlp.html
> >>> http://linrunner.de/en/tlp/docs/tlp-developer-documentation.html
> >>> https://github.com/linrunner/TLP
> >>>
> >>> The SlackBuild
> >>> http://sourceforge.net/projects/mefiles/files/TLP.tar.gz
> >>>
> >>> Its my first SlackBuild so..
> >>> I built it and installed it my side.
> >>>
> >>> Note-
> >>> See the develepor-documentation linked above.
> >>> They have some post install tasks, which I have included in 
> doinst.sh, but there are also some post-remove tasks, which I dont how 
> to incorporate.
> >>
> >> Ok, I tried to improve upon the build script by modifying the 
> configuration files that were being placed in /etc/init.d are now 
> placed as /etc/rc.d/rc.tlp
> >> (The same SlackBuild linked above has been updated)
> >>
> >> But I still need to figure out how to add the tlp service to startup..
> >>
> > Ok, I think I figured out how to add it to startup..add it to 
> /etc/rc.d/rc.local, set in doinst.sh
> > so thats done.
> >
> > But still dont know how to perform post-removal tasks like removal 
> of this line from rc.local or the other settings done in doinst.sh..
> >
> > _______________________________________________
> > SlackBuilds-users mailing list
> > SlackBuilds-users at slackbuilds.org 
> <mailto:SlackBuilds-users at slackbuilds.org>
> > http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
> > Archives - http://lists.slackbuilds.org/pipermail/slackbuilds-users/
> > FAQ - http://slackbuilds.org/faq/
> >
>
> Generally, you want to avoid messing with the user's rc.local. I'd 
> include information on how to add it to rc.local to the README and let 
> them deal with it. You could wrap it in a check for rc.tdp existing so 
> that there's no problem after uninstall, I suppose.
>
> Thanks,
> JK
>
>
>
Thanks!

I think that it makes sense that to install a power saving 
service/daemon like TLP, it should autostart :)
But if I cant remove it from rc.local after installation, I think I will 
leave it to the user..
But there's one more thing..

 From tlp's website-


    Post Installation Script (tlp)

# Disable conflicting pm-utils hooks-
for i in 95hdparm-apm disable_wol hal-cd-polling intel-audio-powersave 
harddrive \ laptop-mode journal-commit pci_devices pcie_aspm readahead 
sata_alpm \ sched-powersave usb_bluetooth wireless xfs_buffer; do if [ 
-x /usr/lib/pm-utils/power.d/$i ]; then ln -sf /usr/lib/tlp-pm/tlp-nop 
/etc/pm/power.d/$i fi done
# Restart acpid – insert distro specific code here

I put this code in doinst.sh .. should I remove it as well if I cant 
make it go back to the original state ?