[Slackbuilds-users] Recoll slackbuild problem

[Willy Sudiarto Raharjo]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> On Mon, 28 Jul 2014, Jeffrey Dick wrote:
> 
>> I've found what looks like a bug in the SlackBuild for Recoll.
>> Even if ENABLE_CAMELCASE is set to NO (the default), the test in
>> the script returns true, and --enable-camelcase is passed to the
>> configure command. The following partial diff shows a corrected
>> version, with whitespace around the == operator:
>> 
>> -if test $ENABLE_CAMELCASE=="YES" +if test $ENABLE_CAMELCASE ==
>> "YES" then CAMEL_CASE_CONFIG="--enable-camelcase" else
>> CAMEL_CASE_CONFIG="" fi
>> 
> 
> Perhaps the style of the if statement could be changed to match the
> rest of the script?
> 
> if [ "$ENABLE_CAMELCASE" = "YES" ]; then 
> CAMEL_CASE_CONFIG="--enable-camelcase" else CAMEL_CASE_CONFIG="" 
> fi
> 
> Or to test for mixed/lower case versions of "YES", something like
> this?
> 
> if [ "${ENABLE_CAMELCASE,,}" = "yes" ]; then 
> CAMEL_CASE_CONFIG="--enable-camelcase" else CAMEL_CASE_CONFIG="" 
> fi

Fixed on my branch

Thanks

- -- 
Willy Sudiarto Raharjo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iEYEARECAAYFAlPd/RUACgkQiHuDdNczM4EaEACeMMGf1+U9V0Ia/IGmfgP4zMdb
TRQAoJ19g5eqIRunwQOOP2HmspvKKjqE
=IUq0
-----END PGP SIGNATURE-----