[Slackbuilds-users] Recoll slackbuild problem

[Richard]

On Mon, 28 Jul 2014, Jeffrey Dick wrote:

> I've found what looks like a bug in the SlackBuild for Recoll. Even if ENABLE_CAMELCASE is set to NO (the default),
> the test in the script returns true, and --enable-camelcase is passed to the configure command. The following partial
> diff shows a corrected version, with whitespace around the == operator:
> 
> -if test $ENABLE_CAMELCASE=="YES"
> +if test $ENABLE_CAMELCASE == "YES"
>     then CAMEL_CASE_CONFIG="--enable-camelcase"
>     else CAMEL_CASE_CONFIG=""
> fi
> 

Perhaps the style of the if statement could be changed to match the rest 
of the script?

if [ "$ENABLE_CAMELCASE" = "YES" ]; then
  CAMEL_CASE_CONFIG="--enable-camelcase"
else
  CAMEL_CASE_CONFIG=""
fi

Or to test for mixed/lower case versions of "YES", something like this?

if [ "${ENABLE_CAMELCASE,,}" = "yes" ]; then
  CAMEL_CASE_CONFIG="--enable-camelcase"
else
  CAMEL_CASE_CONFIG=""
fi

Richard Narron
---------------------------------------------------------------------
Q:  How many existentialists does it take to screw in a lightbulb?
A:  Two.  One to screw it in and one to observe how the lightbulb
    itself symbolizes a single incandescent beacon of subjective
    reality in a netherworld of endless absurdity reaching out toward a
    maudlin cosmos of nothingness.