[Slackbuilds-users] zarfy SlackBuild installs data into /usr/share not /tmp/SBo/...

Richard richard at aaazen.com
Mon Jan 26 18:45:14 UTC 2015


It was pointed out in a LinuxQuestion forum that the zarfy build ignores
the DESTDIR= for the man file and for the image files.

http://www.linuxquestions.org/questions/slackware-14/the-myth-of-once-you-go-slack-you-never-go-back-4175531864/page5.html

It appears that there are bugs in the Makefile.in and src/Makefile.bin
that should be patched in the zarfy.SlackBuild

These patches should work:

---------------------------------------------------------------
$cat patch-makefile-in
--- Makefile.in.orig	2008-09-13 06:05:07.000000000 -0700
+++ Makefile.in	2015-01-26 08:13:00.780325974 -0800
@@ -612,24 +612,24 @@

 install-data-local:
 	@$(NORMAL_INSTALL)
-	  $(mkinstalldirs) $(pkgdatadir); \
+	  $(mkinstalldirs) $(DESTDIR)$(pkgdatadir); \
 	  for fname in data/*; do \
 	    if test -f $$fname; then \
-	      $(INSTALL_DATA) $$fname $(pkgdatadir); \
+	      $(INSTALL_DATA) $$fname $(DESTDIR)$(pkgdatadir); \
 	    fi \
 	  done;
-	  $(mkinstalldirs) $(mandir)/man1; \
-	  $(INSTALL_DATA) man/zarfy.1.gz $(mandir)/man1
+	  $(mkinstalldirs) $(DESTDIR)$(mandir)/man1; \
+	  $(INSTALL_DATA) man/zarfy.1.gz $(DESTDIR)$(mandir)/man1

 uninstall-local:
 	@$(NORMAL_UNINSTALL)
-	  for fname in $(pkgdatadir)/*; do \
+	  for fname in $(DESTDIR)$(pkgdatadir)/*; do \
 	    if test -f $$fname; then \
 	      rm $$fname; \
 	    fi \
 	  done; \
-	rmdir $(pkgdatadir); \
-	rm $(mandir)/man1/zarfy.*
+	rmdir $(DESTDIR)$(pkgdatadir); \
+	rm $(DESTDIR)$(mandir)/man1/zarfy.*
 # Tell versions [3.59,3.63) of GNU make to not export all variables.
 # Otherwise a system limit (for SysV at least) may be exceeded.
 .NOEXPORT:
-----------------------------------------------------------------------
$cat patch-src-makefile-in
--- src/Makefile.in.orig	2008-09-13 06:05:07.000000000 -0700
+++ src/Makefile.in	2015-01-26 08:28:52.276310733 -0800
@@ -200,7 +200,7 @@
 	cd $(top_builddir) && $(MAKE) $(AM_MAKEFLAGS) am--refresh
 install-binPROGRAMS: $(bin_PROGRAMS)
 	@$(NORMAL_INSTALL)
-	test -z "$(bindir)" || $(MKDIR_P) "$(DESTDIR)$(bindir)"
+	test -z "$(DESTDIR)$(bindir)" || $(MKDIR_P) "$(DESTDIR)$(bindir)"
 	@list='$(bin_PROGRAMS)'; for p in $$list; do \
 	  p1=`echo $$p|sed 's/$(EXEEXT)$$//'`; \
 	  if test -f $$p \
------------------------------------------------------------------------

Richard Narron
richard at aaazen.com

P.S.  The README still has the word "positioning" misspelled


More information about the SlackBuilds-users mailing list