[Slackbuilds-users] pyPdf SlackBuild or can't upgrade sofastats

[Brenton Earl]

Hello,

I've resubmitted pyPdf with all relevant files renamed to PyPDF2.  You
can see my changes here:

https://github.com/BrentonEarl/slackbuilds-14.2/commit/d734040db2b21fdbde2b552c750aa4172730eb7b

Let me know if more is required.  Sorry for the confusion and the late
reply.  I've been very busy and have a lot less time to dedicate to SBo
maintenance.

Regards,
Brent


On Sun, Sep 03, 2017 at 05:57:04PM +1000, Duncan Roe wrote:
> On Sun, Aug 27, 2017 at 10:01:01AM +0200, 414N wrote:
> > Hello Duncan,
> > thanks for your reply and sorry for the HTML-only message, I???ll make
> > sure to send plaintext versions too. ;-)
> > While the suggestion of mentioning the usage of |pip2tgz| to obtain
> > pyPdf in the README of sofastats can indeed work as a quite good
> > workaround to the issue at hand, I think there are some drawbacks to it:
> >
> >   * people who use automated tools to install packages (i.e. |sbopkg|)
> >     will build a package that won???t work at runtime, even if all the
> >     other hard-dependencies specified in the |REQUIRES| line are installed
> >   * dependencies specified in the README should only be optional or
> >     recommended ones, not mandatory ones (at least, this is what I
> >     grasped here on SBo)
> >
> > I guess the second one clashes with the guidelines here on SBo, but I
> > don???t know for sure.
> > If someone knows better, please correct me if I???m wrong
> >
> > Cheers
> >
> > ???
> >
> > Alan Alberghini
> >
> > SBo clone: GitHub <https://github.com/414n/slackbuilds.org>
> >
> Hi Alan,
> 
> Sorry for the delay in replying - have had network problems this last week.
> 
> If pyPdf is only a *runtime* dependency, I believe you don't absolutely *have*
> to have it as a requirement.
> 
> But really, the existing package should be renamed. This is not entirely
> trivial: as well as renaming the directory the maintainer would also have to
> rename a couple of files therein and edit the SlackBuild, info and slack-desc.
> 
> The required patches are below. I've cc'd the maintainer (Hi Brent!) in the
> hope he can submit the new SB and withdraw the old one,
> 
> Cheers ... Duncan.
> 
> > On 20/08/2017 05:29, Duncan Roe wrote:
> > > On Sat, Aug 19, 2017 at 06:06:47PM +0200, 414N wrote:
> > >
> > >> I'm working on an updated sofastats SlackBuild but I stumbled upon a
> > >> dependency issue...
> > >> It seems like the sofastats package depends since some time on the `pyPdf`
> > >> python library for managing PDF exports (see the official documentation at
> > >> http://www.sofastatistics.com/wiki/doku.php?id=help:linux_installation#packages_required_dependencies,
> > >> although they only report distro-specific package names...). Problem is,
> > >> that the pyPdf package on SBo is not the original library required for the
> > >> build, but instead is a ~2011 fork based on that library that has since gone
> > >> separate ways and was renamed `PyPDF2`. This is also reflected on the module
> > >> name, as it is installed as PyPDF2 inside
> > >> /usr/lib64/python2.7/site-packages/PyPDF2/.
> > >> The full story of the forking is available on the official site of PyPDF2 at
> > >> https://mstamy2.github.io/PyPDF2/, while the original library is still
> > >> available at http://pybrary.net/pyPdf/.
> > >> What I'd like to propose is:
> > >>
> > >> - to rename the current pyPdf package to the more proper `PyPDF2` name
> > >>
> > >> - to submit (I've already created a SlackBuild) the original unmaintained
> > >> library as `pyPdf`, so the dependency can be set inside the updated
> > >> sofastats.info
> > >> --
> > >> Alan Alberghini
> > > Hi Alan,
> > >
> > > Please try to avoid sending HTML-only messages to the list in future.
> > >
> > > pyPdf is indexed by PyPI - the Python Package Index
> > > (https://pypi.python.org/pypi),  so pip2tgz will build it. The package ends up
> > > as pyPdf-1.13-x86_64-1_pip2_SBo.tgz. (PyPDF2 is also listed on PyPI BTW).
> > >
> > > Unfortunately you can't put a pip2tgz-built package as a dependency in
> > > sofastats.info. You would have to mention it in the README as being required.
> > > That would enable you to get the main SB out the door.
> > >
> > > I certainly agree that the existing pyPdf SB should be renamed,
> > >
> > > Cheers ... Duncan.
>