[Slackbuilds-users] Wrong symlinks in packages

[Jeremy Hansen]

On Thu, May 3, 2018, 7:13 PM Frank Gingras <thumbs at apache.org> wrote:

> Wait, why are you asking for help with salix packages on the SBo mailing
> list?
>
> On Wed, May 2, 2018 at 2:47 PM Didier Spaier <didier at slint.fr> wrote:
>
>> Hello,
>>
>> Today someone nicknamed Jardenblack posted this in a Salix forum:
>> [quoted post]
>> Here is a list of packages that have bad soft links and need to be fixed:
>> fvwm95-2.0.43f-i486-2salix
>> HawkNL-1.68-i486-1salix
>> http-parser-2.7.1-i486-1salix
>> libiptcdata-1.0.4-i486-2salix
>> oss-4.2.2011-i586-1salix
>> PDCurses-3.4-i486-1salix
>> qt3-3.3.8b-i486-5salix
>>
>> example of the problem:
>> ( cd usr/lib ; ln -sf
>> /usr/src/slapt-src/libraries/PDCurses/package-PDCurses/usr/lib/libXCurses.so
>> libXpanel.so )
>>
>> I found this problem searching thur the /var/log/scripts files. I hope
>> this helps.
>> [/quoted post]
>>
>> I couldn't answer because for an unknown reason the thread and the user
>> disappeared.
>>
>> However I had a look at two cases and confirm the issue.
>> For PDCurses the wrong links are mad by by install target in Makefile.in
>> in the source archive as shown below
>> install:
>> <lines removed>
>>         ln -f -s $(libdir)/$(SHLPRE)$(SHLFILE)$(SHLPST) \
>>                 $(libdir)/$(SHLPRE)Xpanel$(SHLPST)
>>         ln -f -s $(libdir)/libXCurses.a $(libdir)/libXpanel.a
>>         -$(RANLIB) $(libdir)/libXpanel.a
>> For fvwm95 the wrong link comes from the install target in
>> sample.fvwmrc/Makefile.in in the source archive as sown below:
>> install:
>>         ${INSTALL_DATA} ${RC} ${fvwm_dir}
>>         ${LN} ${fvwm_dir}/${RC} ${fvwm_dir}/${fvwm_rc}
>> (LN is converted to ln -s during the build)
>>
>> I was too lazy to check the other packages (I don't use any of those
>> listed by Jardenblack)
>> but I assume that other packages have a similar issue, i.e. symlinks
>> from a file in the build dir that will be broken as soon as the build
>> dir is removed.
>>
>> Maybe the broken symlinks do not always hurt but still, a systematic
>> check that the symlinks (in install/doinst.sh or /var/log/scripts) will
>> survive the removal of the build dir could be useful?
>>
>> Best,
>>
>> Didier
>> _______________________________________________
>> SlackBuilds-users mailing list
>> SlackBuilds-users at slackbuilds.org
>> https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
>> Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
>> FAQ - https://slackbuilds.org/faq/
>>
>> _______________________________________________
> SlackBuilds-users mailing list
> SlackBuilds-users at slackbuilds.org
> https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
> Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
> FAQ - https://slackbuilds.org/faq/


He's mentioning that builds from SlackBuilds on SBo have incorrect
symlinks. Just because they're built with a salix tag doesn't mean that the
incorrect symlinks generated when building the packages aren't a problem.

It doesn't sound like this is a SlackBuild issue so much as a program issue
(based on Didier's research on those two packages, although, I haven't
looked into any of them), but the maintainers of those packages might want
to look into it and either contact upstream or correct for it in the
SlackBuild.

Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20180504/dc76b2f7/attachment-0001.html>