[Slackbuilds-users] google-go-lang.SlackBuild Version 1.10.2 + RUN_TEST=true fails with CC=gcc

[Konrad J Hambrick]

Vincent --

I am running Slackware64 14.2 + Multilib on a 4.4.131 Kernel.

I've been building google-go-lang with the RUN_TEST=true option
since last November or so and I've been keeping up with SBo
Updates and RUN_TEST=true has always worked just fine for `go`
versions 1.8.5, 1.9.2 and 1.9.5

However with this weekend's Version 1.10.2 Update, the SlackBuild
failed with RUN_TEST=true on the ../misc/cgo/testsanitizers tests

Log Snippet is below ... but I can send the full log if you like.

I found a number of hits on google about the failure and this one:

   https://github.com/golang/go/issues/14602

suggested setting CC=clang ( for clang .ge. 3.8 ) to get past the
testsanitizers fail.

A very simple patch is attached.

Setting CC=clang did work for me, but I am not sure if it is a good
idea to override gcc with clang ...

I've got a few test programs that I'll be running thru `go` when
I get a break from my work schedule.

I'll let you know if I see any issues with the compiler switch.

Thanks for the google-go-lang.SlackBuild Vincent !

-- kjh

# testsanitizers fail from my SBo build log:
# -----------------------------------------

#### ../misc/cgo/testsanitizers
--- FAIL: TestShared (0.02s)
    --- FAIL: TestShared/tsan_shared (1.61s)
        cshared_test.go:71: `/tmp/TestShared867470121/tsan_shared` exited
with exit status 66
                ==================
                WARNING: ThreadSanitizer: data race (pid=8218)
                  Write of size 8 at 0x7f241f795c70 by thread T1:
                    #0 pthread_attr_getstacksize <null>
(tsan_shared+0x00000041bcf2)
                    #1 x_cgo_init <null> (libtsan_shared.so+0x00000008961f)
                    #2 runtime.rt0_go
/tmp/SBo/package-google-go-lang/usr/lib64/go1.10.2/go/src/runtime/
asm_amd64.s:199 (libtsan_shared.so+0x00000007fdf6)

                  Previous write of size 8 at 0x7f241f795c70 by main thread:
                    #0 <null> <null> (0x000000000001)

                  Location is stack of thread T1.

                  Thread T1 (tid=8225, running) created by main thread at:
                    #0 pthread_create <null> (tsan_shared+0x00000040c604)
                    #1 _cgo_try_pthread_create <null>
(libtsan_shared.so+0x0000000894e0)
                    #2 x_cgo_sys_thread_create <null>
(libtsan_shared.so+0x000000089282)
                    #3 _rt0_amd64_lib
/tmp/SBo/package-google-go-lang/usr/lib64/go1.10.2/go/src/runtime/

<<snip>>

asm_amd64.s:56 (libtsan_shared.so+0x00000007fc26)

                SUMMARY: ThreadSanitizer: data race ??:0 threadentry
                ==================
                ThreadSanitizer: reported 5 warnings
FAIL
2018/05/05 07:08:40 Failed: exit status 1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20180505/208adcd5/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: google-go-lang.SlackBuild-patch-for-RUN_TEST-true.patch
Type: text/x-patch
Size: 806 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20180505/208adcd5/attachment-0001.bin>