[Slackbuilds-users] About owncloud-client SlackBuild

[Matteo Bernardini]

Il giorno ven 9 nov 2018 alle ore 17:13 Luiz Carlos Ramos via
SlackBuilds-users <slackbuilds-users at slackbuilds.org> ha scritto:
>
> Hello,
>
> I tried to build owncloud-client recently and ran into problems. In
> summary, it seems that when "make doc" is executed, an error is shown
> pointing to a lacking "latexmk" utility that would be used to build
> something.
>
> Some googlings after and I found that this utility possibly belongs to
> one of the "texlive" SBo packages (texlive, texlive-doc or
> texlive-extra).  The first is easy to build and install (considering
> also that it collides with a base Slackware package), but the last two
> requires downloading ~1Gb each, and so I didn't feel comfortable in
> building and installing them all.
>
> By the other hand, one possibility is that the documentation could be
> regarded as an optional thing in the whole owncloud-client package.
>
> So I tried to build owncloud-client commenting out the "make doc" step,
> and it worked.
>
> I took an additional step and changed the SlackBuild to allow building
> the package without "make doc" when latexmk is not available. Here is a
> possible patch:
>
> --
> diff --git a/network/owncloud-client/owncloud-client.SlackBuild b/network/owncloud-client/owncloud-client.SlackBuild
> index 0ee0dd35aa12ebbbbe3e4c756a6d4264719f68ce..5903474f96496aee2b695df0630ffeb75350267b 100644
> --- a/network/owncloud-client/owncloud-client.SlackBuild
> +++ b/network/owncloud-client/owncloud-client.SlackBuild
> @@ -22,6 +22,9 @@
>  #  OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
>  #  ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>
> +# Modified by: Luiz Ramos <lramos.prof at yahoo.com.br>: skip "make doc" when
> +# latexmk is not present
> +
>  PRGNAM=owncloud-client
>  VERSION=${VERSION:-2.4.2}
>  BUILD=${BUILD:-1}
> @@ -71,6 +74,9 @@ find -L . \
>   \( -perm 666 -o -perm 664 -o -perm 640 -o -perm 600 -o -perm 444 \
>    -o -perm 440 -o -perm 400 \) -exec chmod 644 {} \;
>
> +HAVE_LATEXMK=$(latexmk -v 2>/dev/null | head -1 || true)
> +test -z "${HAVE_LATEXMK}" && echo "latexmk not found: will not build docs"
> +
>  mkdir -p build
>  cd build
>    cmake \
> @@ -84,7 +90,7 @@ cd build
>      -DBUILD_WITH_QT4=${BUILD_WITH_QT4:-"No"} \
>      ..
>    make VERBOSE=1
> -  make doc
> +  test -n "${HAVE_LATEXMK}" && make doc
>    make install DESTDIR=$PKG
>  cd ..
>
> --
>
> In the same case, I tested it and it worked fine.
>
> This effectively makes something (which in the best of my knowledge is
> texlive and friends) as optional dependencies of owncloud-client.
>
> Of course if you eventually accept this change, it should also be
> advisable to write something in the README file about this optional
> dependency and the effects of not having them.
>
> Many thanks,
>
> Luiz Carlos Ramos
> lramos.prof at yahoo.com.br
> São Paulo - Brazil

hi Luis,

I don't know what is happening in your build environment but just to
confirm that I have tried a few minutes ago to build owncloud-client
without texlive installed on slackware64-14.2 (no latexmk binary is in
my $PATH) and everything went fine (also the "make doc" bit).

Matteo