[Slackbuilds-users] new coturn slackbuild

[Dave Woodfall]

On 2020-04-16 07:35,
Thomas Bourdon <thomas.bourdon at halpanet.org> put forth the proposition:
> Hi,
>
> Thanks Dave! You said you fixed these issues but I can't find the SB fixed.
> It doesn't matter, I also fixed exactly as you say, and I suggest 366 for
> uid/gid.
>
> I just wait to be sure 366 is a good choice, then I'll submit it.
>
> Have a nice day!

I've  attached it for you.

> Le 15/04/2020 à 20:04, Dave Woodfall a écrit :
> > Hi Thomas,
> >
> > I've found a few issues, but otherwise it's good:
> >
> >
> > The .info file:
> >
> > We can't use variables in the .info file like this:
> >
> > https://github.com/coturn/coturn/archive/${VERSION}/${PRGNAM}-${VERSION}.tar.gz
> >
> > This one works:
> >
> > DOWNLOAD="https://github.com/coturn/coturn/archive/4.5.1.1/coturn-4.5.1.1.tar.gz"
> >
> >
> > The SlackBuild:
> >
> > I notice that you've used 900 for UID and GID, and we are only at 365
> > in https://slackbuilds.org/uid_gid.txt
> >
> > It's best to ask for a UID and GID here or in IRC so we can keep
> > track of new numbers added in that list.
> >
> > I've added a note above the copyright notice to say that it's now
> > maintained by you.
> >
> > It's not usually necessary to out the INSTALL file with the documents
> > for /usr/doc (although I'm guilty of that too sometimes.)
> >
> >
> > README:
> >
> > No need to put the homepage in the README, although it may go in the
> > slack-desc.  I've also fixed a typo.
> >
> > slack-desc:
> >
> > The same typo here.
> >
> > There shouldn't be any spaces after the : on blank lines.  It's
> > useful if you have a way of checking for trailing whitespace in your
> > editor.
> >
> > Those are the only issues I could see.
> >
> > Cheers.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: coturn.tar.gz
Type: application/x-gzip
Size: 3651 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20200416/c35e3cd6/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20200416/c35e3cd6/attachment.asc>