[Slackbuilds-users] [Slackware-current] zfs-on-linux

[Andrzej Telszewski]

On 01/01/2021 04:15, David Chmelik wrote:
> On Slackware-current with the 5.10.n kernels, I get this error 
> building zfs-on-linux.  I don't know if the ZFS project updated it for 
> 5.10.n.
>
>       CC [M]  /tmp/SBo/zfs-0.8.5/module/zfs/vdev_disk.o
>    In file included from /tmp/SBo/zfs-0.8.5/include/sys/dmu.h:848,
>                      from /tmp/SBo/zfs-0.8.5/include/sys/spa.h:44,
>                      from /tmp/SBo/zfs-0.8.5/include/sys/spa_impl.h:35,
>                      from /tmp/SBo/zfs-0.8.5/module/zfs/vdev_disk.c:30:
>    /tmp/SBo/zfs-0.8.5/module/zfs/vdev_disk.c: In function 
> ■vdev_disk_open■:
>    /tmp/SBo/zfs-0.8.5/include/linux/blkdev_compat.h:378:37: error:
>    implicit declaration of function ■check_disk_change■; did you mean
>    ■bdev_disk_changed■? [-Werror=implicit-function-declaration]
>       378 | #define vdev_bdev_reread_part(bdev) check_disk_change(bdev)
>           |                                     ^~~~~~~~~~~~~~~~~
>    /tmp/SBo/zfs-0.8.5/module/zfs/vdev_disk.c:218:17: note: in expansion
>    of macro ■vdev_bdev_reread_part■
>       218 |     int error = vdev_bdev_reread_part(bdev);
>           |                 ^~~~~~~~~~~~~~~~~~~~~
>    /tmp/SBo/zfs-0.8.5/module/zfs/vdev_disk.c: In function
>    ■vdev_blkg_tryget■:
>    /tmp/SBo/zfs-0.8.5/module/zfs/vdev_disk.c:506:37: error: ■struct
>    percpu_ref■ has no member named ■count■
>       506 |   rc = atomic_long_inc_not_zero(&ref->count);
>           |                                     ^~
>    cc1: some warnings being treated as errors
>    make[5]: *** [scripts/Makefile.build:279:
>    /tmp/SBo/zfs-0.8.5/module/zfs/vdev_disk.o] Error 1
>    make[4]: *** [scripts/Makefile.build:496:
>    /tmp/SBo/zfs-0.8.5/module/zfs] Error 2
>    make[3]: *** [Makefile:1805: /tmp/SBo/zfs-0.8.5/module] Error 2
>    make[3]: Leaving directory '/usr/src/linux-5.10.4'
>    make[2]: *** [Makefile:30: modules] Error 2
>    make[2]: Leaving directory '/tmp/SBo/zfs-0.8.5/module'
>    make[1]: *** [Makefile:842: all-recursive] Error 1
>    make[1]: Leaving directory '/tmp/SBo/zfs-0.8.5'
>    make: *** [Makefile:711: all] Error 2
>
>
>
For 99% this is a change in the kernel's internal API.
So yes, ZFS project needs to adapt.