Thanks for looking at it Eric!<br><br>Yes, I did not hide the fact that the script was taken from slacky. Sorry about not changing i686 back to i486. I had done that change when I compiled it. I know the slackbuild is very sloppy and that I have to work on it some more. However, before I do, I wanted to make sure that noone else is working on a script since all the work I would make would be a moot point.<br>
<br>Originally, I was going to use the stable release, but I changed it to svn just to run the latest and greatest. I will change it back to use the stable release.<br><br>As far the as the requirements go, I was able to get all the dependencies from <a href="http://slackbuilds.org">slackbuilds.org</a>. The only thing missing is mlt. I have a slackbuild for that also. <br>
<br>Sorry for the sloppy work! I was more concerned with the meat of the script that I overlooked the commented area. This is what I get for trying to do this stuff late at night! :^/<br><br>-stn<br><br><div class="gmail_quote">
On Wed, Aug 5, 2009 at 12:37 PM, Eric Hameleers (SBo) <span dir="ltr"><<a href="mailto:alien@slackbuilds.org">alien@slackbuilds.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
stormtracknole schreef:<br>
<div><div></div><div class="h5">> List,<br>
><br>
> I modified slacky it kdenlive Slackbuild to follow more closely the<br>
> requirements for Slackbuilds.org. So, before I submit my SlackBuild, is<br>
> there anyone else planning on adding kdenlive once Slackware 13 comes<br>
> out? Just wanted to make sure before I submit it. Also, can someone<br>
> take a look at what I have come up with so far and give me some<br>
> pointers? The script will build kdenlive from svn instead of the<br>
> standard package. I also have a slackbuild for mlt which is a big<br>
> requirement. Thanks ahead of time! :^)<br>
><br>
> -stn<br>
><br>
> Here's the kdenlive.Slackbuild:<br>
><br>
> #!/bin/sh<br>
><br>
> # Slackware build script for <appname><br>
><br>
> # Written by (your name) (your contact information)<br>
><br>
> # (add license information here if you desire; otherwise,<br>
><br>
> # all submissions are considered to be in the public domain)<br>
> # Some licenses may incorporate the "Written by" information<br>
> # above, and if so, that line can be omitted<br>
> # We strongly suggest *not* using GPL for scripts, as it requires<br>
><br>
> # a copy of the GPL to be distributed with it. Since the GPL<br>
> # itself is longer than any build script will be, this just doesn't<br>
> # make good sense...<br>
><br>
> # |-----------------------------------------------------------------| #<br>
><br>
> # REMOVE THIS ENTIRE BLOCK OF TEXT #<br>
> #<br>
> # $Id: template.SlackBuild,v 1.8 2009/05/27 01:34:37 slackbuilds Exp slackbuilds $<br>
> #<br>
> # This template is not meant to be a 'cut and paste' script to<br>
> # enable any random user to make a working package. While<br>
><br>
> # we're certainly not discouraging use of this template, if<br>
> # you haven't manually gone through each step of the process<br>
> # without the build script (typically as a normal user, as this<br>
> # will reveal problems that you won't see as root), then there's<br>
><br>
> # a good chance that something important is missing from your<br>
> # submission.<br>
><br>
> # When using this template script, please remove as many of<br>
> # these unnecessary comments as possible. Commented code is<br>
> # a good thing, but if it's obvious, there's no need to comment it.<br>
><br>
> #<br>
> # AGAIN, REMOVE THE COMMENTS IF THEY ARE NOT NEEDED - DON'T JUST<br>
> # DELETE THIS BLOCK OF TEXT WITHOUT BOTHERING TO READ WHAT'S IN IT.<br>
> #<br>
> # |-----------------------------------------------------------------| #<br>
<br>
</div></div>... etc ...<br>
<br>
When I look at this SlackBuild header, it tells me that you really<br>
have not paid attention to what it is trying to tell you.<br>
Perhaps you should read it and follow up on it.<br>
<br>
Also, since you have copied the slacky.eu script almost verbatim (see<br>
<a href="http://repository.slacky.eu/slackware-12.1/multimedia/kdenlive/20080610/src/kdenlive.SlackBuild" target="_blank">http://repository.slacky.eu/slackware-12.1/multimedia/kdenlive/20080610/src/kdenlive.SlackBuild</a>)<br>
it would be prudent to credit the original author in your version,<br>
although though this is not required here (the original script does<br>
not have a copyright header).<br>
<div class="im"><br>
> ARCH=${ARCH:-i686} # this should not change<br>
<br>
</div>Hmm. Out template (like all the rest of Slackware packages) has this line:<br>
<br>
ARCH=${ARCH:-i486} # this should not change<br>
<br>
It would be good if you stuck to the template.<br>
<br>
I'll be looking for your next post with the updated script.<br>
<br>
Finally two more points:<br>
<br>
(1) we do not approve scripts that check out SVN sources. You will<br>
have to think of something here (look at other contributions on our<br>
site that use SVN snapshots to get an idea).<br>
(2) This software has a ton of dependencies. You will have to write a<br>
README that lists what other scripts are required from SlackBuilds.org<br>
- any missing dependencies need to be submitted as scripts by<br>
yourself as well.<br>
<br>
Cheers, Eric<br>
_______________________________________________<br>
SlackBuilds-users mailing list<br>
<a href="mailto:SlackBuilds-users@slackbuilds.org">SlackBuilds-users@slackbuilds.org</a><br>
<a href="http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users" target="_blank">http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users</a><br>
Archives - <a href="http://lists.slackbuilds.org/pipermail/slackbuilds-users/" target="_blank">http://lists.slackbuilds.org/pipermail/slackbuilds-users/</a><br>
FAQ - <a href="http://slackbuilds.org/faq/" target="_blank">http://slackbuilds.org/faq/</a><br>
<br>
</blockquote></div><br>