<div class="gmail_quote">On Thu, Dec 17, 2009 at 7:42 AM, Niels Horn <span dir="ltr"><<a href="mailto:niels.horn@gmail.com">niels.horn@gmail.com</a>></span> wrote:<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div><div class="h5">
<br>
</div></div>Some more suggestions... (hey, you asked for it :D )<br>
<br></blockquote><div><br></div><div>Yup, really thanks for the patches and suggestions! ;D It's too late last night so I sent the mail and then went to bad and have been sleeping till noon.... ;(</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
1) config file<br>
<br>
Instead of entering mu name & e-mail every time (they don't change<br>
that much), save them in a file called /etc/sbo-dev-helver.cfg<br>
<br></blockquote><div><br></div><div>Good idea. But instead of a system wide configuration, I prefer a per-user configuration. Could ~/.sbo-dev-helver.cfg be ok?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
2) <a href="http://template.info" target="_blank">template.info</a> / slack-desc.template<br>
<br>
It was not very clear what should be in these files, but I think I<br>
managed to build them by reading the scripts.<br>
<br></blockquote><div><br></div><div>When I wake up in the noon I realized that I didn't doc what these files are... ;( I will add a description somewhere.</div><div><br></div><div>And for sbo admins, would you like to add a folder to contain all the template files(slack-desc, info, SlackBuild) somewhere like <a href="ftp://ftp.slackbuilds.org/templates">ftp://ftp.slackbuilds.org/templates</a> ? Then it will be very convenient for users to follow the changes. I remember I missed the info changes when 13.0 was out ;)</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
3) new_pkg<br>
- It warns when "approved" is not set, but AFAIK it shouldn't<br></blockquote><div><br></div><div>Hmm, yes, this is a problem.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
- The md5sum check does not always work. Some download links simply do<br>
not end with the filename... :( So I guess this should be a warning,<br>
not an error<br></blockquote><div><br></div><div>Hmm, yes, reasonable.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
- I think the solution to add files can be improved. I have several<br>
SlackBuilds with extra files (patches / README.Slackware / etc.). I<br>
suggest adding everything to the tarball, *except*: *.tar.?g* / *~ /<br>
<other_backup_files><br>
<div><div></div><div class="h5"></div></div></blockquote></div><div><br></div><div>Hmm, my hobbit is untar the source in the working directory and have a look at it and write/modify the SlackBuild etc. And the working dir maybe really dirty -- have log files, swp files, and other files that shouldn't be in the tarball. So I prefer the "white list" approach than the "black list" approach. What do you think?</div>
<br>-- <br>Cheers,<br>Grissiom<br>