<br><br><div class="gmail_quote">On Tue, Feb 7, 2012 at 5:24 AM, Audrius Kažukauskas <span dir="ltr"><<a href="mailto:audrius@neutrino.lt">audrius@neutrino.lt</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Mon, 2012-02-06 at 11:35:53 -0600, Charles Kauffman wrote:<br>
> 2.<br>
> In the echinus.SlackBuild<br>
> sed -i "s;-Os;$SLKCFLAGS ;g" <a href="http://config.mk" target="_blank">config.mk</a><br>
> sed -i "s;.pixmap: ;.pixmap: \/usr\/share\/echinus\/_g" echinusrc<br>
> sed -i "s/DOCPREFIX}\/echinus/DOCPREFIX}\/echinus-$VERSION/g" Makefile<br>
><br>
> The source only contains Makefile and <a href="http://config.mk" target="_blank">config.mk</a>, no configure script. So I<br>
> replaced the compiler flag -Os with SLKCFLAGS, as well as had the script<br>
> create a doc directory that had the version number appended to it.<br>
> The second sed makes modifications to the rc file since problems can occur<br>
> when the program loads.<br>
><br>
> So, does that look good, or should I just leave some of that alone?<br>
<br>
</div>Looks good to me. As long as the changes don't break anything, I'd say<br>
go for it. Just not sure if global (g) substitute is needed (it looks<br>
for multiple regex matches in a single line). Also there should be a<br>
semicolon at the end of second sed-line, no (and no need to escape<br>
slashes)?<br></blockquote><div><br></div><div><br></div><div>Thanks for the info on (g). Had thought it would stop after the first find/replace. Anyway it worked just fine without it, so you were right that it wasn't necessary.</div>
<div><br></div><div>As for the escape slashes, I had forgotten about them while testing and editing the script until after I uploaded it to Slackbuilds, but then I don't think it would fail having them in there.</div>
<div><br></div><div>Charles</div><div><br></div><div><br></div><div><br></div><div> </div></div>