<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body>
<p>Hi,</p>
<p>Thanks Dave! You said you fixed these issues but I can't find the
SB fixed. It doesn't matter, I also fixed exactly as you say, and
I suggest 366 for uid/gid.</p>
<p>I just wait to be sure 366 is a good choice, then I'll submit it.</p>
<p>Have a nice day!</p>
<p><br>
</p>
<div class="moz-cite-prefix">Le 15/04/2020 à 20:04, Dave Woodfall a
écrit :<br>
</div>
<blockquote type="cite"
cite="mid:20200415180418.GC31407@blackswan.r0t.uk">
<pre class="moz-quote-pre" wrap="">Hi Thomas,
I've found a few issues, but otherwise it's good:
The .info file:
We can't use variables in the .info file like this:
<a class="moz-txt-link-freetext" href="https://github.com/coturn/coturn/archive/$">https://github.com/coturn/coturn/archive/$</a>{VERSION}/${PRGNAM}-${VERSION}.tar.gz
This one works:
DOWNLOAD=<a class="moz-txt-link-rfc2396E" href="https://github.com/coturn/coturn/archive/4.5.1.1/coturn-4.5.1.1.tar.gz">"https://github.com/coturn/coturn/archive/4.5.1.1/coturn-4.5.1.1.tar.gz"</a>
The SlackBuild:
I notice that you've used 900 for UID and GID, and we are only at 365
in <a class="moz-txt-link-freetext" href="https://slackbuilds.org/uid_gid.txt">https://slackbuilds.org/uid_gid.txt</a>
It's best to ask for a UID and GID here or in IRC so we can keep
track of new numbers added in that list.
I've added a note above the copyright notice to say that it's now
maintained by you.
It's not usually necessary to out the INSTALL file with the documents
for /usr/doc (although I'm guilty of that too sometimes.)
README:
No need to put the homepage in the README, although it may go in the
slack-desc. I've also fixed a typo.
slack-desc:
The same typo here.
There shouldn't be any spaces after the : on blank lines. It's
useful if you have a way of checking for trailing whitespace in your
editor.
Those are the only issues I could see.
Cheers.
--
Dave
The antibloat squad!
For those interested in no bloat, minimal desktop Linux
gopher://tty1.uk/1/?minimal-linux
<a class="moz-txt-link-freetext" href="http://tty1.uk/minimal-linux">http://tty1.uk/minimal-linux</a>
#minimallinux @ chat.freenode.net
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<pre class="moz-quote-pre" wrap="">_______________________________________________
SlackBuilds-users mailing list
<a class="moz-txt-link-abbreviated" href="mailto:SlackBuilds-users@slackbuilds.org">SlackBuilds-users@slackbuilds.org</a>
<a class="moz-txt-link-freetext" href="https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users">https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users</a>
Archives - <a class="moz-txt-link-freetext" href="https://lists.slackbuilds.org/pipermail/slackbuilds-users/">https://lists.slackbuilds.org/pipermail/slackbuilds-users/</a>
FAQ - <a class="moz-txt-link-freetext" href="https://slackbuilds.org/faq/">https://slackbuilds.org/faq/</a>
</pre>
</blockquote>
<div class="moz-signature">-- <br>
Thomas Bourdon</div>
</body>
</html>