[Slackbuilds-users] More 14.0 prep...

[Binh Nguyen]

On Thu, 13 Sep 2012 17:36:46 -0500
Robby Workman <rworkman at slackbuilds.org> wrote:

> On Thu, 13 Sep 2012 19:10:27 +0700
> Binh Nguyen <binhnguyen at fastmail.fm> wrote:
> 
> > On Thu, Sep 13, 2012, at 08:59 AM, Robby Workman wrote:
> > > 
> > > Finally, have a look at the commits since master in my branch of 
> > > the templates repo:
> > >   http://slackbuilds.org/cgit/templates/log/?h=rworkman
> > > Assuming that's understandable by everyone, I think I'll get that
> > > merged into master pretty soon (and it will branch for 14.0 just
> > > like the slackbuilds repo).
> > > 
> > 
> > A suggestion: Change
> > 
> > find . \
> >  \( -perm 777 -o -perm 775 -o -perm 711 -o -perm 555 -o -perm 511
> > \) \ -exec chmod 755 {} \; -o \
> >  \( -perm 666 -o -perm 664 -o -perm 600 -o -perm 444 -o -perm 440 -o
> >  -perm 400 \) \
> >  -exec chmod 644 {} \;
> > 
> > to
> > 
> > chmod -R u+w,go+r-w,a+X-s .
> > 
> > 
> > The later is much shorter, easier to understand; and it covers the
> > former one.
> 
> 
> I like that one better too, but I think there was some corner case
> that volkerdi found where it didn't do the same thing.  Perhaps your
> line is slightly different than what we had though...
> 
> -RW

Maybe, just maybe, because of the '-s' part, there could be some issues
when re-packaging binaries if binaries have special stuff.

Otherwise, I think it works fine.