[Slackbuilds-users] spice is not picking up lz4 support

[Robby Workman]

On Fri, 24 Feb 2017 14:22:26 +0100
Matteo Bernardini <matteo.bernardini at gmail.com> wrote:

> 2017-02-24 14:19 GMT+01:00 Matteo Bernardini
> <matteo.bernardini at gmail.com>:
> > 2017-02-24 12:32 GMT+01:00 Duncan Roe <duncan_roe at acslink.net.au>:  
> >> Hi Matteo,
> >>
> >> This looks to be an upstream bug.
> >>
> >> I built and installed the latest lz4 (1.7.5), but spice does not
> >> build with LZ4 support.
> >>
> >> Looking at config.log, I think I can see the problem:
> >>
> >>   $PKG_CONFIG --exists --print-errors "liblz4 >= 129"
> >>
> >> What has happened is: lz4 used to have plain numeric revs. The
> >> last of these was 131, released on Jun 29, 2015. After that, lz4
> >> changed to x.y.z revision format, starting with 1.7.3 released on
> >> Nov 17, 2016.
> >>
> >> The proper fix is to spice-common/m4/spice-deps.m4:188, which
> >> should be expanded to accept either >= 129 or >= 1.7.3.  
> >
> > yes, it's definitely an upstream bug: a quick fix should be to
> > modify the SlackBuild like this
> >
> > --- ./spice.SlackBuild.orig     2017-02-23 11:12:28.218760310 +0100
> > +++ ./spice.SlackBuild  2017-02-24 14:14:43.292547670 +0100
> > @@ -78,6 +78,9 @@
> >   \( -perm 666 -o -perm 664 -o -perm 600 -o -perm 444 -o -perm 440
> > -o -perm 400 \) \
> >   -exec chmod 644 {} \;
> >
> > +sed -i "s|129|1.7.3|" spice-common/m4/spice-deps.m4
> > +autoreconf -fi
> > +
> >  CFLAGS="$SLKCFLAGS" \
> >  CXXFLAGS="$SLKCFLAGS" \
> >  ./configure \  
> 
> but it seems it's already fixed in the newer spice-common (included in
> spice), so it will probably will go in the next spice release
> 
> https://cgit.freedesktop.org/spice/spice-common/commit/?id=48da2c6654f37fcf02711aa86a08d6404dd6d215


Here's the patch (slightly modified to fix the dir); apply with:
  patch -p1 < $CWD/fix-lz4-detection.diff

See attached.

-RW 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-lz4-detection.diff
Type: text/x-patch
Size: 1951 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20170224/3a8ca389/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20170224/3a8ca389/attachment.asc>