[Slackbuilds-users] system/dstat slackbuild cannot extract tarball

[B. Watson]

On Sun, 28 Jul 2024, Arkadiusz Drabczyk wrote:

> Some slackbuilds try multiple tarball names and dstat does it too but
> it uses incorrect name, it should be:
>
>     tar xvf $CWD/$PRGNAM-$VERSION.tar.gz || tar xvf 
> $CWD/v$VERSION.tar.gz
>
> There is a similar problem in network/ngrep but this script is more
> optimistic and does not try different tarballs:
>
>     tar xvf $CWD/$PRGNAM-$SOURCEVERSION.tar.gz
>
> It will not work with sbopkg neither.

Right, but it's easily fixed. The maintainer should just follow this
guide:

https://slackbuilds.org/GITHUB_URLs.txt

> And there is network/radicale/radicale.SlackBuild which tries 3
> different tarball names including the version with `v` at the
> beginning that dstat has missed but it isn't checked in $CWD:
>
>     tar xvf $CWD/$PRGNAM-$VERSION.tar.gz || tar xvf 
> $CWD/Radicale-$VERSION.tar.gz || tar xvf v$VERSION.tar.gz
>
> so that will not work neither. Interestingly in this case wget gets a
> correct filename even w/o using --content-disposition:

Right. Because radicale does use a "canonical" github download link.
The extra code that checks for various other tarball filenames could
be removed, since it's not needed.

sbolint attempts to flag this issue, but might not be 100% reliable.