[Slackbuilds-users] bug in irqbalance

Scott J. Harmon harmon at ksu.edu
Mon Sep 1 03:05:37 UTC 2008


Robby Workman wrote:
> Patrick J. Volkerding wrote:
>> Grissiom wrote:
>>> Hi all,
>>> The irqbalance could only take into effect only if run as root. So
>>> here is
>>> my patch:
>>
>> Even if something only works for root, IMHO it is better to get
>> upstream to make location changes.  That way other things (scripts,
>> perhaps) won't try to run with an absolute path of /usr/bin/
>> expecting to find it there.
>
>
> Yep, agreed, now that I see what the proposed change was.
> Thanks, Alan and Scott, for pointing out my eyesight troubles. ;-)
>
>
>> On the occasions that things have been moved like this without
>> involving upstream, we've at least placed a symlink in the old,
>> official upstream location to avoid those possible problems.
>
>
> In this case, I don't think we gain anything from the move, so this can
> be my official NAK on the proposed patch.
>
> To the original poster: send the suggestion to the irqbalance developers.
> If they make the change, then we'll obviously follow it.
>
> -RW
>
Just my observation from the patch, but it seems that the slackbuild is
manually installing it, indicating that there is no 'make install' (or
that the make install is broken).

Of course, this is just an observation from the patch, I have not looked
at the complete slackbuild nor the irqbalance sources. ;-)

-- 
Scott J. Harmon
PhD Candidate
Kansas State University

"Computer Science is no more about computers than astronomy is about telescopes." - Edsger Dijkstra



More information about the SlackBuilds-users mailing list