[Slackbuilds-users] Build script for html2ps 1.0b7 is broken.

[Robby Workman]

On Wed, 10 Sep 2014 22:29:33 -0500
Robby Workman <rworkman at slackbuilds.org> wrote:

> On Tue, 9 Sep 2014 23:11:32 +0200 (CEST)
> Kees Theunissen <C.J.Theunissen at differ.nl> wrote:
> 
> > After that the "doinst.sh" script complains at install time about a
> > missing "etc/html2ps/html2psrc.new" file.
> > 
> > I'm not sure how to handle this. The global configuration file is
> > (with the above patch applied) installed in
> > "/usr/share/html2ps/html2psrc" without a ".new" extention. I guess
> > that the maintainer (RW) moved the file intentionally away from /etc
> > and that the ".new" extention was also removed by intention because
> > the file contains mostly build-time parameters and should not be
> > considered as a real configuration file. In that case should the
> > line "config etc/html2ps/html2psrc.new" and the "config()"
> > subroutine be removed from "doinst.sh".
> 
> 
> This one happens regardless.  I honestly have no idea why that is.
> I don't know if there used to be an htmlsrc file in /etc and that
> upstream removed it, or if I used to move the file from /usr/share
> to /etc, or maybe some other combination.  Probably the best bet
> at this point is to just kill that part from doinst.sh and forget
> about it, given that nobody's noticed it (indicating lack of use 
> of this package) and that it doesn't seem necessary under usual
> conditions.  I'll get that fixed up in my git branch.


Followup on just this part:

commit e03cbc615a3085aac1c93d6d9d5a31d8fe55cdf3
Author: Robby Workman <rworkman at slackbuilds.org>
Date:   Wed Sep 10 22:33:19 2014 -0500

    misc/html2ps: Fix leftover cruft in doinst.sh ; rm bashisms
    
    Looking at a1437bd04fa9, it appears that I probably left that
    config() bit in doinst.sh accidentally as a leftover from an
    earlier idea of how to handle the config-ish file, and since
    I completely forgot about the mere presence of the doinst.sh
    script in the build script itself, I certainly didn't go back
    and proof the postinstall afterward.  Hey, nobody's perfect,
    right?  :-)
    
    Signed-off-by: Robby Workman <rworkman at slackbuilds.org>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20140910/264a4cd8/attachment.asc>