[Slackbuilds-users] Kodi doesn't build anymore (fmt)

[Jeremy Hansen]

On Sun, Oct 16, 2022, 11:15 AM martin schmidt <martin.schmidt13 at gmx.de>
wrote:

> Hi,
>
> according to https://github.com/xbmc/xbmc/pull/21649/commits
> we need a patch for builds with libfmt 9.0.0
>
> I adapted the patch so it does work now with the Slackbuild for kodi 19.4
>
> Here it comes - enjoy :-)
>
> diff --git a/xbmc/utils/GLUtils.cpp b/xbmc/utils/GLUtils.cpp
> index 1ef804709f..df8921e2b0 100644
> --- a/xbmc/utils/GLUtils.cpp
> +++ b/xbmc/utils/GLUtils.cpp
>
> @@ -148,29 +149,29 @@ void _VerifyGLState(const char* szfile, const char*
> szfunction, int lineno)
>   void LogGraphicsInfo()
>   {
>   #if defined(HAS_GL) || defined(HAS_GLES)
> -  const GLubyte *s;
> +  const char* s;
>
> -  s = glGetString(GL_VENDOR);
> +  s = reinterpret_cast<const char*>(glGetString(GL_VENDOR));
>     if (s)
> -    CLog::Log(LOGINFO, "GL_VENDOR = %s", s);
> +    CLog::Log(LOGINFO, "GL_VENDOR = {}", s);
>     else
>       CLog::Log(LOGINFO, "GL_VENDOR = NULL");
>
> -  s = glGetString(GL_RENDERER);
> +  s = reinterpret_cast<const char*>(glGetString(GL_RENDERER));
>     if (s)
> -    CLog::Log(LOGINFO, "GL_RENDERER = %s", s);
> +    CLog::Log(LOGINFO, "GL_RENDERER = {}", s);
>     else
>       CLog::Log(LOGINFO, "GL_RENDERER = NULL");
>
> -  s = glGetString(GL_VERSION);
> +  s = reinterpret_cast<const char*>(glGetString(GL_VERSION));
>     if (s)
> -    CLog::Log(LOGINFO, "GL_VERSION = %s", s);
> +    CLog::Log(LOGINFO, "GL_VERSION = {}", s);
>     else
>       CLog::Log(LOGINFO, "GL_VERSION = NULL");
>
> -  s = glGetString(GL_SHADING_LANGUAGE_VERSION);
> +  s = reinterpret_cast<const
> char*>(glGetString(GL_SHADING_LANGUAGE_VERSION));
>     if (s)
> -    CLog::Log(LOGINFO, "GL_SHADING_LANGUAGE_VERSION = %s", s);
> +    CLog::Log(LOGINFO, "GL_SHADING_LANGUAGE_VERSION = {}", s);
>     else
>       CLog::Log(LOGINFO, "GL_SHADING_LANGUAGE_VERSION = NULL");
>
> diff --git a/xbmc/windowing/X11/WinSystemX11.cpp
> b/xbmc/windowing/X11/WinSystemX11.cpp
> index 8a18288fd8..cdb2a1da2e 100644
> --- a/xbmc/windowing/X11/WinSystemX11.cpp
> +++ b/xbmc/windowing/X11/WinSystemX11.cpp
>
> @@ -1038,7 +1048,10 @@ bool CWinSystemX11::HasWindowManager()
>
>     if(status == Success && items_read)
>     {
> -    CLog::Log(LOGDEBUG,"Window Manager Name: %s", data);
> +    const char* s;
> +
> +    s = reinterpret_cast<const char*>(data);
> +    CLog::Log(LOGDEBUG, "Window Manager Name: {}", s);
>     }
>     else
>       CLog::Log(LOGDEBUG,"Window Manager Name: ");
>


I'm the maintainer and already submitted a fix, I just screwed up and left
an extra command in the SlackBuild, so I'll be resubmitting later today.

Is there a reason you messaged the mailing list instead of me directly (or
at least cc'ing me in this message)? In general, you should always message
the maintainer as not all of them are subscribed to the mailing list.

Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20221016/0ccc737a/attachment.htm>