[Slackbuilds-users] ripe-atlas-tools

[nnb]

Hello :)

Am 14.10.26 um 16:45 schrieb Marco Moock:
> Hello!
> 
> I've created some Slackbuilds for ripe-atlas-tools (the CLI tools to 
> create network measurements).
> 
> They are my first ones where Python is involved.
> 
> Is the usage of setup.py right here?

Seems fine, but all three tools mention Python 3.10 and upwards in
setup.py. You need to make sure they really work fine on stable with
the old outdated Python 3.9.

> The tools need some extra Python modules that are hosted in a separate 
> git repo.
> 
> Is it right to have multiple Slackbuilds here?

I think this is correct. I noticed ripe-atlas-cousteau and ripe-atlas-
sagan have no dependencies listed in the .info file. It looks like
they won't work without ripe-atlas-tools, so I would just list this
as REQUIRES="ripe-atlas-tools". Then if it gets installed via automated
tools it will pull in all the main dependencies anyway (assuming it
doesn't need additional ones).

> I've attached them to the mail, feel free to give suggestions for 
> improvement.

Maybe just nitpicking, but the template for python has been updated
mainly the find and chmod part. Might be better to have this included
for new submits.
https://slackbuilds.org/templates/python-template.SlackBuild


Best regards,
-- 
nnb