[Slackbuilds-users] mozplugger

[ciol]

Hi, the last mozplugger version is 1.10.0 (1.8.1 in slackbuilds.org)
Changing $VERSION in mozplugger.Slackbuild is not enough, because of 
Makefile_i686.diff or Makefile_i486.diff.
I can rewrite them if you want.

But, I believe these files are not needed. Also I don't think that:
sed -i "s?\(root=\)?\1 $PKG?g" Makefile
in the slackbuild is useful.

I explain.

* Makefile_i486.diff does the following things:
-NORM_CFLAGS=
+NORM_CFLAGS=-O2 -march=i486 -mtune=i686

(and Makefile_i686 optimizes for i686).

But one can do:
make NORM_CFLAFS="$SLKCFLAGS" linux instead, in the slackbuild.
With $SLKCFLAGS defined as usual.

However, there is no more NORM_CFLAGS in the Makefile. I think a safe 
hack would be to use RPM_OPT_FLAGS instead
(make RPM_OPT_CFLAFS="$SLKCFLAGS" linux)
Anyway, I don't think mozplugger needs to be optimized.


* Same for sed, one can simply do:
make root=$PKG install

(I don't like sed)

* Then, there are:
-	- at mkdir -p $(root)$(prefix)/share/man/man7
+	- at mkdir -p $(root)$(prefix)/man/man7

and

-	cp mozplugger.7 $(root)$(prefix)/share/man/man7/
+	cp mozplugger.7 $(root)$(prefix)/man/man7/

in Makefile_{i486,i686}.diff
Since /usr/share/man is a symbolic link to /usr/man, it is not useful.