[Slackbuilds-users] Few bugs I noticed

[Jakub Jankowski]

Hi,

while rebuilding my x86_64 box recently, I've found few bugs in 
SlackBuilds. Some of them spotted just by reading the code, some were 
revealed after adding 'set -e'. I don't think any of these bugs is 
related to building on a non-x86-slackware system and I think they're 
worth fixing anyway.

Sorry in advance for the format, it's just a find | xargs cat of some 
helper files I keep locally.

1.
./network/kadu
# There is a hardcoded i486 in the configure line. Is it intentional?
#   --build=i486-slackware-linux

2. (see 9 too)
./multimedia/mplayer
# the part of mplayer.SlackBuild where link to font
# is created looks like this:
#   ln -fs /usr/share/fonts/TTF/\$font subfont.ttf
# but instead it shouldn't have the leading slash:
#   ln -fs usr/share/fonts/TTF/\$font subfont.ttf

3.
./multimedia/x264
# x264 version 20070722 isn't sufficent for multimedia/mplayer.
# if you upgrade to newer version, be careful - recent versions
# (I tested on 20081112) don't support --enable-gtk switch.

4.
./multimedia/k9copy
# k9copy's README says:
#   NOTE: libdvdread and libdvdnav conflict; DO NOT INSTALL BOTH.
# but libraries/libdvdread/README and libraries/libdvdnav/README don't
# mention it. In fact, libdvdnav's README says:
#   libdvdnav requires libdvdread, also available from Slackbuilds.org

5.
./libraries/libmp4v2
# there seems to be a template for man pages included in the final build
# in $PKG/usr/man/manm. it's useless, why just don't remove it with this:
#   rm -rf $PKG/usr/man/manm

6.
./audio/speex
# the chown root:root line is commented out

7.
./network/ipcalc
# this is a simple perl script that installs to /usr/bin
# and /usr/lib/cgi-bin (why there?)... is there any reason
# it's not a 'noarch'? there are no binary components.

8.
./audio/audacity
# there are leftovers from times when 1.3.x was beta. So this:
# rm -rf $PRGNAM-src-$VERSION-beta
# and this:
# cp -rf $TMP/$PRGNAM-src-$VERSION-beta/locale/*.po $PKG/usr/share/locale/
# is wrong and shouldn't contain the "-beta" part.
# Also, audacity's README doesn't mention possible use of soundtouch.


And ninth, general question. Aren't doinst.sh scripts supposed to contain 
*all* the paths relative to the /? There are lots of SlackBuilds that 
use /usr/bin/update-mime-database or /usr/bin/update-desktop-database in 
doinst.sh.

I hope you find those issues relevant. 

Thanks for the good work, BTW :-)

Cheers,
 Jakub.

-- 
Jakub Jankowski|shasta at toxcorp.com|http://toxcorp.com/
GPG: FCBF F03D 9ADB B768 8B92 BB52 0341 9037 A875 942D