[Slackbuilds-users] Jmol 12.0.39 SB script

[Audrius Kažukauskas]

On Sun, 2011-04-03 at 12:33:45 +0200, Ivan Pavicevic wrote:
> This script makes tgz package from Jmol's java binary. The script makes jmol
> branch in /opt and then makes symbolic link to /usr/bin. Also, I made
> jmol.desktop, and added jmol.png as icon, so after installation Jmol appears
> in Applications/Education section (I'm using Xfce).
> It works, but if you find anything wrong in the script, please let me know.

I had a quick peek into your script and it doesn't look like it was
based on any of SBo templates[0].  I suggest to follow them as closely
as possible.  To handle different program and source file names, you
could use SRC_NAME (or something similar) for the latter one.  The
former should be PRGNAM as written in templates.

[0] http://slackbuilds.org/templates/

Documentation in Slackware should be placed in /usr/doc, not
/usr/share/doc.  Icon file should be placed in /usr/share/pixmaps, that
way you won't have to provide a full path for it in .desktop file.

And there are some issues with .desktop file:

  $ desktop-file-validate jmol.desktop
  jmol.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated
  jmol.desktop: error: value "Application;Education" for string list key
  "Categories" in group "Desktop Entry" does not have a semicolon (';')
  as trailing character

I haven't tried to run it, but overall it looks okay, just needs to be
written more closely to SBo guidelines.

-- 
Audrius Kažukauskas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20110405/f313d493/attachment.asc>