[Slackbuilds-users] Clementine build failed on CURRENT x86_64

[David Woodfall]

On (29/07/13 14:47), Mark Halstead <mdhalstead at att.net> put forth the proposition:
>I hardly expect you to maintain for CURRENT. This was just a heads-up 
>for next go-round. I can make it work for myself. Thanks for paying 
>attention and maintaining an excellent piece of software.
>
>Mark H.
>
>On 07/29/2013 01:34 PM, David Woodfall wrote:
>>On (29/07/13 10:50), Mark Halstead <mdhalstead at att.net> put forth 
>>the proposition:
>>>I only track CURRENT so not sure. I suspect that it will build ok, 
>>>but perhaps do something bad to "gnome-volume-control" for those 
>>>that might use it. GLib-2.36 is the culprit. Perhaps someone who 
>>>runs 14.0 could try it?
>>>
>>>Mark H.
>>
>>Yes it does build on 14.0. It is designed to build on the repo branch
>>that is chosen when searching on slackbuilds.org.
>>
>>I do not support building it on -current as it would be a
>>nightmare to keep up with all the changes.
>>
>>You may notice that on the slackbuilds.org website there is no option
>>in the drop-down box for -current, so whether it builds or not in
>>-current is irrelevant.
>>
>>Anyway, thanks for bringing this to my attention. If needed, the fix
>>will be put into the 14.1 version when it is released.
>>
>>Regards
>>
>>D.
>>
>>>On 07/29/2013 10:32 AM, Willy Sudiarto Raharjo wrote:
>>>>>The last couple of updates broke Clementine for me. Seems to 
>>>>>be a "warning
>>>>>treated as error" thing, but the fix seems simple. At line 286 of
>>>>>src/main.cpp g_type_init is deprecated and according to 
>>>>>documentation no
>>>>>longer does anything.
>>>>>
>>>>>  // This makes us show up nicely in gnome-volume-control
>>>>>  g_type_init(); /* THIS LINE 286 */
>>>>>g_set_application_name(QCoreApplication::applicationName().toLocal8Bit());
>>>>>
>>>>>
>>>>>I commented it out and the build went smoothly. Based on the 
>>>>>Gnome go-object
>>>>>documentation, I think this line can safely be removed.
>>>>Will it broke users using Slackware 14.0?

I can confirm that it does build and run on 14.0 with the patch I
made from OP's info. I can't tell if it works any better with
gnome-volume-control (or at all). That particular app seems to be part
of the much larger gnome control center, which I don't feel inclined
to build at the moment.

If anyone does want to test though I've attached the patch. Just needs

patch -p1 --verbose < $CWD/gnome-vol.patch

before 'mkdir build' in the slackbuild.

D.



-------------- next part --------------
diff -Naur a/src/main.cpp b/src/main.cpp
--- a/src/main.cpp	2012-11-18 08:51:27.000000000 +0000
+++ b/src/main.cpp	2013-07-29 21:59:53.149781604 +0100
@@ -265,7 +265,7 @@
 #endif
 
   // This makes us show up nicely in gnome-volume-control
-  g_type_init();
+  //g_type_init();
   g_set_application_name(QCoreApplication::applicationName().toLocal8Bit());
 
   RegisterMetaTypes();