[Slackbuilds-users] libvirt SlackBuild running domains detection

[Robby Workman]

On Tue, 16 Dec 2014 22:23:23 +0100
Mathieu Bouillaguet <mathieu.bouillaguet at gmail.com> wrote:

> The libvirtd startup script included in the current SlackBuild doesn't
> reliably detetct running domains and consequently doesn't stop them
> when stopping the libvirt daemon.
> 
> Currently it executes a grep on the keyword 'running'. This doesn't
> work on system with localized variables since the word 'running' will
> be translated.
> 
> A reliable way would be to use the command "virsh list --name
> --state-running" which outputs the name of the currently running
> domains.
> 
> On another subject it may be good to use the configure option
> --qemu-user to run the qemu virtual machines with another user than
> root.
> 
> It is stronlgy recommended by upstream :
> "It is possible to change this default by using the
> --with-qemu-user=$USERNAME and --with-qemu-group=$GROUPNAME arguments
> to 'configure' during build. It is strongly recommended that vendors
> build with both of these arguments set to 'qemu'."
> http://libvirt.org/drvqemu.html#securitydac
> 
> Currently all qemu virtual machnie are executed with root user and
> priviledges unless it is built with optional dependency libcapng. See
> http://libvirt.org/drvqemu.html#securitycap


commit bb44a8de7f7927a431c49c13416d49e2f670d8e6
Author: Robby Workman <rworkman at slackbuilds.org>
Date:   Fri Dec 19 23:46:35 2014 -0600

    libraries/libvirt: Make rc.libvirt more robust
    
    Detecting running domains by grepping for "running" isn't very
    effective for non-english strings, so let's fix that.
    Since I was already there, I cleaned up a few more nits.
    Thanks to Mathieu Bouillaguet for the report and solution.
    
    TODO: use --with-qemu-user=qemu and --with-qemu-group=qemu
          per upstream recommendation; this will have to be in
          sync with the qemu build here (with respect to what
          actual user and group names are used)
    
    Signed-off-by: Robby Workman <rworkman at slackbuilds.org>

-RW
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20141219/35ad6b0b/attachment.asc>