[Slackbuilds-users] Kivy - is this OK?

[Ryan P.C. McQuen]

>~~~~
>tar xvf $CWD/$SRCNAM-$VERSION.tar.gz || >xvf $CWD/$VERSION.tar.gz
>~~~~

Just a typo, needs 'tar' in front of the second command.



But may I suggest changing it to:

if [ -e $CWD/$VERSION.tar.gz ]; then
  tar xvf $CWD/$VERSION.tar.gz
else
  tar xvf $CWD/$SRCNAM-$VERSION.tar.gz
fi

That way you won't get an error message if the file isn't there in one
form.  ;-)


On Fri, Jan 16, 2015, 6:05 PM Thomas Szteliga <ts at websafe.pl> wrote:

I've built Kivy on multiple machines with slpkg, but now there's a
problem with the same slackbuild:

~~~~
+==============================================================================
| MD5SUM check for 1.8.0.tar.gz [ PASSED ]
+==============================================================================

tar: /tmp/slpkg/build/Kivy/kivy-1.8.0.tar.gz: Cannot open: No such file
or directory
tar: Error is not recoverable: exiting now
./Kivy.SlackBuild: line 64: xvf: command not found
Total build time for package Kivy : 0.14 Sec
~~~~

The problematic line is:

~~~~
tar xvf $CWD/$SRCNAM-$VERSION.tar.gz || xvf $CWD/$VERSION.tar.gz
~~~~

Is that OK: "|| xvf $CWD/$VERSION.tar.gz"?

IMVHO it should be " || tar xvf $CWD/$VERSION.tar.gz" or am I wrong?
                        ^^^

On other machines I had "--content-disposition" in wget flags,
on this machine I forgot about setting this, that's why the part
after "||" is being called.

--
Thomas Szteliga

_______________________________________________
SlackBuilds-users mailing list
SlackBuilds-users at slackbuilds.org
http:// <http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users>
lists.slackbuilds.org
<http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users>/mailman/
<http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users>listinfo
<http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users>/
<http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users>slackbuilds
<http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users>-users
<http://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users>
Archives - http://
<http://lists.slackbuilds.org/pipermail/slackbuilds-users/>
lists.slackbuilds.org
<http://lists.slackbuilds.org/pipermail/slackbuilds-users/>/
<http://lists.slackbuilds.org/pipermail/slackbuilds-users/>pipermail
<http://lists.slackbuilds.org/pipermail/slackbuilds-users/>/
<http://lists.slackbuilds.org/pipermail/slackbuilds-users/>slackbuilds-users
<http://lists.slackbuilds.org/pipermail/slackbuilds-users/>/
<http://lists.slackbuilds.org/pipermail/slackbuilds-users/>
FAQ - http:// <http://slackbuilds.org/faq/>slackbuilds.org
<http://slackbuilds.org/faq/>/ <http://slackbuilds.org/faq/>faq
<http://slackbuilds.org/faq/>/ <http://slackbuilds.org/faq/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20150117/648dbd93/attachment.html>