[Slackbuilds-users] new coturn slackbuild

[Thomas Bourdon]

Hi,

Thanks Dave! You said you fixed these issues but I can't find the SB 
fixed. It doesn't matter, I also fixed exactly as you say, and I suggest 
366 for uid/gid.

I just wait to be sure 366 is a good choice, then I'll submit it.

Have a nice day!


Le 15/04/2020 à 20:04, Dave Woodfall a écrit :
> Hi Thomas,
>
> I've found a few issues, but otherwise it's good:
>
>
> The .info file:
>
> We can't use variables in the .info file like this:
>
> https://github.com/coturn/coturn/archive/${VERSION}/${PRGNAM}-${VERSION}.tar.gz
>
> This one works:
>
> DOWNLOAD="https://github.com/coturn/coturn/archive/4.5.1.1/coturn-4.5.1.1.tar.gz"
>
>
> The SlackBuild:
>
> I notice that you've used 900 for UID and GID, and we are only at 365
> in https://slackbuilds.org/uid_gid.txt
>
> It's best to ask for a UID and GID here or in IRC so we can keep
> track of new numbers added in that list.
>
> I've added a note above the copyright notice to say that it's now
> maintained by you.
>
> It's not usually necessary to out the INSTALL file with the documents
> for /usr/doc (although I'm guilty of that too sometimes.)
>
>
> README:
>
> No need to put the homepage in the README, although it may go in the
> slack-desc.  I've also fixed a typo.
>
> slack-desc:
>
> The same typo here.
>
> There shouldn't be any spaces after the : on blank lines.  It's
> useful if you have a way of checking for trailing whitespace in your
> editor.
>
> Those are the only issues I could see.
>
> Cheers.
>
> --
> Dave
>
> The antibloat squad!
> For those interested in no bloat, minimal desktop Linux
> gopher://tty1.uk/1/?minimal-linux
> http://tty1.uk/minimal-linux
> #minimallinux @ chat.freenode.net
>
> _______________________________________________
> SlackBuilds-users mailing list
> SlackBuilds-users at slackbuilds.org
> https://lists.slackbuilds.org/mailman/listinfo/slackbuilds-users
> Archives - https://lists.slackbuilds.org/pipermail/slackbuilds-users/
> FAQ - https://slackbuilds.org/faq/
>
-- 
Thomas Bourdon
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20200416/0b92f8c6/attachment.htm>