[Slackbuilds-users] Build script for html2ps 1.0b7 is broken.

[Robby Workman]

On Tue, 9 Sep 2014 23:11:32 +0200 (CEST)
Kees Theunissen <C.J.Theunissen at differ.nl> wrote:

> Hello,
> 
> 
> The build script for html2ps version 1.0b7 installs most files
> in a rather uncommon place: below usr/share/html2ps/.
> 
> [...]
> Creating Slackware package:  /tmp/html2ps-1.0b7-noarch-2_SBo.tgz
> 
> ./
> install/
> install/doinst.sh
> install/slack-desc
> usr/
> usr/bin/
> usr/bin/xhtml2ps
> usr/share/
> usr/share/pixmaps/
> usr/share/pixmaps/xhtml2ps.png
> usr/share/html2ps/
> usr/share/html2ps/bin/
> usr/share/html2ps/bin/html2ps
> usr/share/html2ps/lib/
> usr/share/html2ps/lib/html2ps/
> usr/share/html2ps/lib/html2ps/html2psrc
> usr/share/html2ps/lib/html2ps/hyphen.tex
> usr/share/html2ps/lib/html2ps/html2ps.html
> usr/share/html2ps/man/
> usr/share/html2ps/man/man5/
> usr/share/html2ps/man/man5/html2psrc.5
> usr/share/html2ps/man/man1/
> usr/share/html2ps/man/man1/html2ps.1
> usr/share/applications/
> usr/share/applications/xhtml2ps.desktop
> usr/man/
> usr/man/man5/
> usr/man/man1/
> usr/doc/
> usr/doc/html2ps-1.0b7/
> usr/doc/html2ps-1.0b7/LICENSE.xhtml2ps
> usr/doc/html2ps-1.0b7/xhtml2ps/
> usr/doc/html2ps-1.0b7/html2ps.ps
> usr/doc/html2ps-1.0b7/COPYING
> usr/doc/html2ps-1.0b7/html2ps.SlackBuild
> usr/doc/html2ps-1.0b7/README
> usr/doc/html2ps-1.0b7/README.xhtml2ps
> 
> Slackware package /tmp/html2ps-1.0b7-noarch-2_SBo.tgz created.
> [...]
> 
> 
> 
> The patch below seems to fix this but is not tested thoroughly.
> 
> 
> 
> $ diff -u html2ps.SlackBuild.original html2ps.SlackBuild
> diff -u html2ps.SlackBuild.original html2ps.SlackBuild
> --- html2ps.SlackBuild.original	2013-11-22 20:47:41.000000000
> +0100 +++ html2ps.SlackBuild	2014-09-09 22:33:33.351567811
> +0200 @@ -60,7 +60,6 @@
>  mkdir -p
> $PKG/usr/{bin,man/man{1,5},share/html2ps,doc/$PRGNAM-$VERSION}
> 
>  printf "
> -
>  n
>  ${PKG}/usr/bin
>  ${PKG}/usr/share/html2ps
 

I can't reproduce this here:

root at liberty:/home/source/SBo/DONE/html2ps# less /tmp/html2ps-1.0b7-noarch-2_SBo.tgz 
drwxr-xr-x root/root         0 2014-09-10 22:22 ./
drwxr-xr-x root/root         0 2014-09-10 22:22 install/
-rw-r--r-- root/root       512 2014-09-10 22:22 install/doinst.sh
-rw-r--r-- root/root       662 2014-09-10 22:22 install/slack-desc
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/doc/
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/doc/html2ps-1.0b7/
-rw-r--r-- root/root      3185 2014-09-10 22:22 usr/doc/html2ps-1.0b7/html2ps.SlackBuild
-rw-r--r-- root/root      1212 2010-05-07 06:28 usr/doc/html2ps-1.0b7/README.xhtml2ps
-rw-r--r-- root/root     17970 2010-05-07 06:28 usr/doc/html2ps-1.0b7/LICENSE.xhtml2ps
-rw-r--r-- root/root     98350 2014-09-10 22:22 usr/doc/html2ps-1.0b7/html2ps.ps
-rw-r--r-- root/root      2185 2010-05-07 06:55 usr/doc/html2ps-1.0b7/README
-rw-r--r-- root/root     17982 2010-05-07 06:27 usr/doc/html2ps-1.0b7/COPYING
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/doc/html2ps-1.0b7/xhtml2ps/
-rw-r--r-- root/root     61487 2014-09-10 22:22 usr/doc/html2ps-1.0b7/html2ps.html
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/share/
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/share/pixmaps/
-rw-r--r-- root/root     17143 2014-09-10 22:22 usr/share/pixmaps/xhtml2ps.png
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/share/applications/
-rw-r--r-- root/root       191 2014-09-10 22:22 usr/share/applications/xhtml2ps.desktop
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/share/html2ps/
-rw-r--r-- root/root       337 2014-09-10 22:22 usr/share/html2ps/html2psrc
-rw-r--r-- root/root     27667 2014-09-10 22:22 usr/share/html2ps/hyphen.tex
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/man/
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/man/man5/
-rw-r--r-- root/root     10940 2014-09-10 22:22 usr/man/man5/html2psrc.5.gz
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/man/man1/
-rw-r--r-- root/root      4234 2014-09-10 22:22 usr/man/man1/html2ps.1.gz
drwxr-xr-x root/root         0 2014-09-10 22:22 usr/bin/
-rwxr-xr-x root/root    132317 2014-09-10 22:22 usr/bin/html2ps
-rwxr-xr-x root/root     84761 2014-09-10 22:22 usr/bin/xhtml2ps


What's different there that causes the second "return" to be unneeded,
I wonder?  :/


> After that the "doinst.sh" script complains at install time about a
> missing "etc/html2ps/html2psrc.new" file.
> 
> I'm not sure how to handle this. The global configuration file is
> (with the above patch applied) installed in
> "/usr/share/html2ps/html2psrc" without a ".new" extention. I guess
> that the maintainer (RW) moved the file intentionally away from /etc
> and that the ".new" extention was also removed by intention because
> the file contains mostly build-time parameters and should not be
> considered as a real configuration file. In that case should the line
> "config etc/html2ps/html2psrc.new" and the "config()" subroutine be
> removed from "doinst.sh".


This one happens regardless.  I honestly have no idea why that is.
I don't know if there used to be an htmlsrc file in /etc and that
upstream removed it, or if I used to move the file from /usr/share
to /etc, or maybe some other combination.  Probably the best bet
at this point is to just kill that part from doinst.sh and forget
about it, given that nobody's noticed it (indicating lack of use 
of this package) and that it doesn't seem necessary under usual
conditions.  I'll get that fixed up in my git branch.

-RW
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://lists.slackbuilds.org/pipermail/slackbuilds-users/attachments/20140910/cf0e17e5/attachment-0001.asc>