[Slackbuilds-users] [ANN]: sbo-dev-helper project

[Niels Horn]

On Wed, Dec 16, 2009 at 9:09 PM, Niels Horn <niels.horn at gmail.com> wrote:
> On Wed, Dec 16, 2009 at 3:26 PM, Niels Horn <niels.horn at gmail.com> wrote:
>>
>> On Wed, Dec 16, 2009 at 2:56 PM, Grissiom <chaos.proton at gmail.com> wrote:
>>>
>>> Hello everyone,
>>> I did a little project named sbo-dev-helper which contain helper scripts that ease your dev progress for SBo.
>>> Project hosted in: http://gitorious.org/sbo-dev-helper
>>> It have 3 scripts by now:
>>>   new_SlackBuild:
>>>     A script to establish a new SlackBuild working directory.
>>>   new_pkg
>>>     A script that create a tarball that you intent to submit to SBo.
>>>   update_sbo_tpl
>>>     A script that get template updates from SBo and notify you if there is any.
>>> Hope they could be helpful.
>>> Any suggestions or patches are welcome ;)
>>> --
>>> Cheers,
>>> Grissiom
>>>
>> Grissiom,
>>
>> Sounds interesting. I'll take a look when I'm back home.
>>
>> I can't check the scripts here at work (firewall blocks about everything), but I already have some suggestions (if you haven't thought of them already):
>>
>> - new_pkg could check if there are any *.tar.?z* files in the directory and warn (if the maintainer forgot to delete the source)
>> - new_pkg could skip *~ files (old backups)
>> - new_slackbuild could already pre-format the slack-desc file (put the name of the package with the ":")
>>
>> I started something similar for myself, but it is way too messy to offer the public :)
>>
>> Regards,
>>
>> Niels
>
>
> Grissiom,
>
> The update_sbo_tpl does not use the SBO_TEMPLATES variable all the
> way, and echo "\t" does not work correctly in bash.
>
> I patched the file like this:
>
> --- sbo-dev-helper/usr/bin/update_sbo_tpl    2009-12-16 21:03:45.000000000 -0200
> +++ /usr/bin/update_sbo_tpl    2009-12-16 21:01:56.000000000 -0200
> @@ -7,12 +7,12 @@
>
>  wget http://www.slackbuilds.org/template.SlackBuild -O
> $SBO_TEMPLATES/template.SlackBuild.new
>
> -if [ "$(cat templates/template.SlackBuild | md5sum -)" \
> -    != "$(cat templates/template.SlackBuild.new | md5sum -)" ]; then
> -    echo "\ttemplate.SlackBuild have changed!!!"
> -    echo "\tConsider update your SlackBuilds!"
> -    echo "\tNew template file restored as
> $SBO_TEMPLATES/template.SlackBuild.new"
> +if [ "$(cat $SBO_TEMPLATES/template.SlackBuild | md5sum -)" \
> +    != "$(cat $SBO_TEMPLATES/template.SlackBuild.new | md5sum -)" ]; then
> +    printf "\ttemplate.SlackBuild have changed!!!"
> +    printf "\tConsider update your SlackBuilds!"
> +    printf "\tNew template file restored as
> $SBO_TEMPLATES/template.SlackBuild.new"
>      exit 1
>  else
> -    rm templates/template.SlackBuild.new
> +    rm $SBO_TEMPLATES/template.SlackBuild.new
>  fi
>
>
> Off to check the other scripts now...
>
> Niels
>

Some more suggestions... (hey, you asked for it :D )

1) config file

Instead of entering mu name & e-mail every time (they don't change
that much), save them in a file called /etc/sbo-dev-helver.cfg

2) template.info / slack-desc.template

It was not very clear what should be in these files, but I think I
managed to build them by reading the scripts.

3) new_pkg
- It warns when "approved" is not set, but AFAIK it shouldn't
- The md5sum check does not always work. Some download links simply do
not end with the filename... :( So I guess this should be a warning,
not an error
- I think the solution to add files can be improved. I have several
SlackBuilds with extra files (patches / README.Slackware / etc.). I
suggest adding everything to the tarball, *except*: *.tar.?g* / *~ /
<other_backup_files>

Niels