[Slackbuilds-users] Support for Python 3 in python-pillow?

[Brenton Earl]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

The only problem I see with adding support for both 2 and 3 is that
your python3-pillow will conflict with the official Slackware package
when 14.2 is released.  I believe that Pat's python-pillow is a
dependency of hplip, and maybe other packages.  I haven't checked what
else though.  For this reason, my package is intended to be removed
once 14.2 is out.  It might be good to test your SlackBuild on
- -current before submitting it.

On 12/15/2015 09:48 AM, Philip Lacroix wrote:
> Hi all
> 
> I've built a test python3-pillow with support for both Python
> versions, where Python 2 is built *after* Phyton 3.
> 
> There is no difference in the resulting content of /usr/bin with
> respect to python-pillow (and the shabang in all files is the
> default #!/usr/bin/python). The only difference is the additional 
> /usr/lib{$LIBDIRSUFFIX}/python3.x directory. This shouldn't cause 
> anything to break if python-pillow is replaced with python3-pillow,
> and the software I'm packaging (which would have python3-pillow as
> a requirement) is happy with this.
> 
> If you guys have nothing against it, I'll submit a new
> python3-pillow SlackBuild according to the above points.
> 
> Philip
> 
> 
> Am 15.12.2015 17:00 schrieb Brenton Earl:
>> -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
>> 
>> I did not intend on adding python 3 support to my python-pillow 
>> SlackBuild.  This SlackBuild is a dependency of my mitmproxy 
>> SlackBuild.  Another dependency that needs to be updated is
>> urwid, which exists in Slackware.  I am not able to submit
>> mitmproxy due to urwid being too outdated in 14.1.  I cannot test
>> in -current either because I need version urwid 1.3.1 and only
>> 1.3.0 is available.  None of this requires python 3.
>> 
>> I discussed with one of the SBo admins that prior to creating my 
>> python-pillow SlackBuild that it would be removed once 14.2 was 
>> released.  I would not recommend relying on my python-pillow
>> package for this reason.  Anyway, it exists -current and will be
>> apart of Slackware in the future.  So track the version in
>> -current rather than mine.
>> 
>> If you really need python 3 support for Pillow, then you should
>> create a separate python3-pillow SlackBuild.
>> 
>> 
>> On 12/15/2015 07:53 AM, David Spencer wrote:
>>> Hi, sorry to have been late catching up with this thread,
>>> 
>>> I think a single SlackBuild that auto-detects python3 is a 
>>> horrible idea for python-pillow.  It would cause an instant 
>>> regression the moment that someone with python3 upgrades 
>>> python-pillow-SBo to the python2-only python-pillow in -current
>>> or 14.2.  A separate python3-pillow would "just work" now, and
>>> would still "just work" after 14.2 is released, unless Patrick
>>> is suddenly going to move 14.2 to python3 and change his 
>>> python-pillow.
>>> 
>>> -D.
>>> 
>>> On 15 December 2015 at 13:12, Philip Lacroix
>>> <slackph at posteo.de> wrote:
>>>> Am 14.12.2015 23:19 schrieb B Watson:
>>>>> 
>>>>> What happens if someone needs both python 2 and 3 support?
>>>>> 
>>>>> Does the python3 stuff actually conflict with the python2 
>>>>> stuff? If not, maybe it'd be good to allow building both 
>>>>> instead of choosing only one or the other.
>>>> 
>>>> 
>>>> Removed redundant assignments in the case construct:
>>>> 
>>>> ##### B1="2"; B2=""
>>>> 
>>>> if [ "${PYTHON3SUPPORT:-no}" == "yes" ]; then case
>>>> "$BUILD_FIRST" in 2) B2="3" ;; 3) B1="3"; B2="2" ;; *) B1="3"
>>>> ;; esac fi
>>>> 
>>>> python$B1 setup.py install --root=$PKG if [[ -n $B2 ]]; then 
>>>> python$B2 setup.py install --root=$PKG fi #####

- -- 
Brenton Earl
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBCAAGBQJWcE4QAAoJEMAWbOXyIOfzosMH/2fm0f40/IiZZs6WTSqJx1J4
xiSRRV86hjdlXoLsElkOZr5CFQjfJL1bikNJm/JOGGufP89Pol7qH6HUjxFrSpZM
oSH0uvljGFHrW9qcuP/hi2BmkWBNC45P+5kzYxaxXKFRC8WMI0NuoTm5MnLXjkPI
ffTX5oXOpYbW0I4P+Hh9vur7RN3NJnJnQm0xEdlMnDi8g6kewBGm3RqLqaoQTxJi
YZNSmCwIyw2JbFKprY8FRcgaQlbyFbnTSJ3G1FoPI4nZgdoIys1wohZmEoSNhD/8
SWddPCJZlJwrJ2bdsVh7gAVJ1FVrgwIAvKMIiCLVchSMOXekwjth7QncNASGfd8=
=XOmI
-----END PGP SIGNATURE-----